Tighten validation of hvncat
implementation
#43940
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in #43933 , a user may run into an unexpected array if they attempt to concatenate arrays using the multidimensional syntax but don't know the semicolon precedence rules:
Naively, one might think these expressions would work, assuming
;
had lowest precedence. The_typed_hvncat_dims
implementation needed to do more to check the dimensions of the arguments.Fixes #43933
Should be backported to 1.7, yes?