Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractInterpreter: make it easier to overload pure/concrete-eval #44224

Merged
merged 1 commit into from
Feb 18, 2022
Merged

AbstractInterpreter: make it easier to overload pure/concrete-eval #44224

merged 1 commit into from
Feb 18, 2022

Conversation

aviatesk
Copy link
Sponsor Member

These changes are necessary to fix #44174 "nicely".

I'd like to backport these changes also.

@aviatesk aviatesk added the backport 1.8 Change should be backported to release-1.8 label Feb 17, 2022
@aviatesk aviatesk requested a review from Keno February 17, 2022 11:09
@aviatesk aviatesk mentioned this pull request Feb 17, 2022
Closed
@vchuravy vchuravy added the needs tests Unit tests are required for this change label Feb 17, 2022
@KristofferC KristofferC mentioned this pull request Feb 18, 2022
Merged
33 tasks
@aviatesk aviatesk merged commit daa0849 into master Feb 18, 2022
@aviatesk aviatesk deleted the avi/pureconcrete branch February 18, 2022 14:05
KristofferC pushed a commit that referenced this pull request Feb 19, 2022
@aviatesk @KristofferC
AbstractInterpreter: make it easier to overload pure/concrete-eval (#…
5f0d551 
…44224)

fix #44174.

(cherry picked from commit daa0849)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Feb 24, 2022
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
@aviatesk @staticfloat
AbstractInterpreter: make it easier to overload pure/concrete-eval (J…
c4e0237 
…uliaLang#44224)

fix JuliaLang#44174.
@maleadt maleadt mentioned this pull request Mar 7, 2022
Closed
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@aviatesk @LilithHafner
AbstractInterpreter: make it easier to overload pure/concrete-eval (J…
24cf350 
…uliaLang#44224)

fix JuliaLang#44174.
This was referenced Dec 31, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@Keno Keno Awaiting requested review from Keno

Assignees
No one assigned
Labels
needs tests Unit tests are required for this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Purity modeling broke overlay tables
4 participants
@aviatesk @vtjnash @vchuravy @KristofferC