Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nothrow check for get_binding_type #44229

Merged
merged 1 commit into from
Feb 18, 2022
Merged

fix nothrow check for get_binding_type #44229

merged 1 commit into from
Feb 18, 2022

Conversation

simeonschaub
Copy link
Member

This got missed in #43671.

@simeonschaub simeonschaub added this to the 1.8 milestone Feb 17, 2022
@simeonschaub simeonschaub added backport 1.8 Change should be backported to release-1.8 embarrassing-bugfix Whoops! labels Feb 17, 2022
@KristofferC KristofferC mentioned this pull request Feb 18, 2022
Merged
33 tasks
@simeonschaub simeonschaub merged commit 6c51d9e into master Feb 18, 2022
@simeonschaub simeonschaub deleted the sds/fix_get_binding_type_nothrow branch February 18, 2022 18:04
vtjnash
vtjnash reviewed Feb 18, 2022
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

KristofferC pushed a commit that referenced this pull request Feb 19, 2022
@simeonschaub @KristofferC
fix nothrow check for get_binding_type (#44229)
9e634bc 
This got missed in #43671.

(cherry picked from commit 6c51d9e)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Feb 24, 2022
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
@simeonschaub @staticfloat
fix nothrow check for get_binding_type (JuliaLang#44229)
6c649e6 
This got missed in JuliaLang#43671.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@simeonschaub @LilithHafner
fix nothrow check for get_binding_type (JuliaLang#44229)
c56093f 
This got missed in JuliaLang#43671.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
embarrassing-bugfix Whoops!
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@simeonschaub @vtjnash @KristofferC