Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile.Allocs: jl_raw_alloc_t.task is untyped pointer #44269

Merged

Conversation

jpsamaroo
Copy link
Member

No description provided.

Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @jpsamaroo!

@KristofferC KristofferC added the backport 1.8 Change should be backported to release-1.8 label Feb 19, 2022
@IanButterworth
Copy link
Member

merging because while buildbot linux64 is very backed up, buildkite linux64 passed (except for an unrelated Distributed failure)

@IanButterworth IanButterworth merged commit 2714b92 into JuliaLang:master Feb 20, 2022
@IanButterworth
Copy link
Member

Is this warning on master related?

/home/ian/Documents/GitHub/julia/src/gc.c: In function 'ijl_gc_managed_malloc':
/home/ian/Documents/GitHub/julia/src/gc.c:3578:35: warning: request for implicit conversion from 'void *' to 'jl_value_t *' {aka 'struct _jl_value_t *'} not permitted in C++ [-Wc++-compat]
 3578 |     maybe_record_alloc_to_profile(b, sz, (jl_datatype_t*)jl_buff_tag);
      |                                   ^
/home/ian/Documents/GitHub/julia/src/gc.c: In function 'gc_managed_realloc_':
/home/ian/Documents/GitHub/julia/src/gc.c:3620:35: warning: request for implicit conversion from 'void *' to 'jl_value_t *' {aka 'struct _jl_value_t *'} not permitted in C++ [-Wc++-compat]
 3620 |     maybe_record_alloc_to_profile(b, sz, jl_gc_unknown_type_tag);

KristofferC pushed a commit that referenced this pull request Feb 23, 2022
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Feb 24, 2022
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants