-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #43411, wrapped NamedTuple
can be bitstype more often
#44311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like jl_get_fieldtypes
is sometimes invalid for NamedTuple, as a special case here:
Line 1519 in afd9926
ndt->types = jl_emptysvec; // XXX: this is essentially always false |
But if Ah, I see we were incorrectly returning jl_get_fieldtypes
was returning svec()
here, how did we end up returning 1
from this function?0
here earlier, since the fieldtypes we considered were incorrect.
Is this comment unnecessary now? Lines 228 to 229 in afd9926
|
(cherry picked from commit f20d5de)
(cherry picked from commit f20d5de)
(cherry picked from commit f20d5de)
fix #43411