Instrument address space passes and friends #44579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
approved these changes
Mar 14, 2022
pchintalapudi
force-pushed
the
pc/addrspace-stat
branch
from
044d710
to
d888ca4
Compare
pchintalapudi
force-pushed
the
pc/addrspace-stat
branch
from
d888ca4
to
53aa4d6
Compare
pchintalapudi
force-pushed
the
pc/addrspace-stat
branch
from
53aa4d6
to
0c8e2b2
Compare
pchintalapudi
added
the
merge me
pchintalapudi
force-pushed
the
pc/addrspace-stat
branch
from
0c8e2b2
to
d84b48c
Compare
|
Tests are failing on all systems here. |
vtjnash
reviewed
Apr 7, 2022
| @@ -452,6 +453,7 @@ bool removeAddrspaces(Module &M, AddrspaceRemapFunction ASRemapper) | |||
| } | |||
| } | |||
|
|
|||
| verifyModule(M); | |||
There was a problem hiding this comment.
Suggested change
| verifyModule(M); |
vtjnash
reviewed
Apr 7, 2022
| @@ -32,6 +33,7 @@ static bool removeNI(Module &M) | |||
| } | |||
| dlstr.erase(nistart, niend - nistart); | |||
| M.setDataLayout(dlstr); | |||
| assert(!verifyModule(M)); | |||
There was a problem hiding this comment.
Suggested change
| assert(!verifyModule(M)); |
|
|
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.