Move to a pool of threadsafecontexts #44605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchintalapudi
force-pushed
the
pc/context-pool
branch
from
15ae2d2 to
4a81edc
Compare
pchintalapudi
force-pushed
the
pc/imaging-mode
branch
3 times, most recently
from
bfbee62 to
a91ff11
Compare
pchintalapudi
force-pushed
the
pc/context-pool
branch
from
4a81edc to
ab97f7d
Compare
pchintalapudi
force-pushed
the
pc/imaging-mode
branch
from
a91ff11 to
f476a3f
Compare
pchintalapudi
force-pushed
the
pc/context-pool
branch
from
ab97f7d to
c1a3ae0
Compare
pchintalapudi
force-pushed
the
pc/imaging-mode
branch
from
f476a3f to
ea197ce
Compare
pchintalapudi
force-pushed
the
pc/context-pool
branch
from
c1a3ae0 to
69566a0
Compare
pchintalapudi
force-pushed
the
pc/context-pool
branch
2 times, most recently
from
5de4749 to
c57ca9f
Compare
pchintalapudi
force-pushed
the
pc/context-pool
branch
from
c57ca9f to
7102da2
Compare
pchintalapudi
added
compiler:codegen
vtjnash
approved these changes
Apr 7, 2022
| @@ -1165,10 +1176,6 @@ void JuliaOJIT::RegisterJITEventListener(JITEventListener *L) | |||
| } | |||
| #endif | |||
|
|
|||
| orc::ThreadSafeContext &JuliaOJIT::getContext() { | |||
unlock order does not matter, only which locks you are already holding when attempting to acquire a new lock |
pchintalapudi
added
merge me
pchintalapudi
force-pushed
the
pc/context-pool
branch
from
c173550 to
6d143d8
Compare
This was referenced Apr 8, 2022
Closed
pchintalapudi
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to a pool of contexts gets us closer to running compilation on multiple threads once we can get rid of the codegen lock. However, this series of PRs is starting to veer into territory of potential locking issues, so review with an eye for those errors would be appreciated.
I don't believe there are locking issues here because although we have differences in the order in which we unlock locks (due to RAII and explicit unlock calls coexisting), we don't really call any functions between our unlock calls which could reacquire an out-of-order lock.
Depends on #44600 to remove imaging_mode.