-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONOTMERGE] Revert "Put off major collections to improve GC times." #44631
Conversation
This reverts commit 80346c1.
Aw man.. I didn't test on win32. If this is the problem I can come up with a less aggressive heuristic for 32bit builds. |
So, it looks like @IanButterworth Any idea why |
I don't see an error? |
See e.g. https://build.julialang.org/#/builders/42/builds/3478/steps/5/logs/stdio. Probably the first thing to do is to change the test to print out what the output was on failure, so we can see if it's something dumb. |
This design fix might help #44639 Otherwise, I don't think there's been a recent change on windows profiling |
#44639 tester_win32 didn't get OOM-ed and failed with the same error, so it seems neither PR are fixes? |
The OOM error is somewhat intermittent. It would be good to fix the Profile error if we can to get a cleaner signal on the OOM. |
I added some debug logs to #44639 the subprocess is either taking ages or frozen and gets killed by the watchdog.
so this test appears to be going really slow on win32
|
Should we have a |
More debug in #44639 The profile test just passed and the subprocess took 20s. On MacOS it takes ~3s, on my Windows VM with 32-bit julia it takes 10s. When it fails it means it's being killed after 120s, which seems like a big deviation from normal CI behavior. Also, that run got OOM-ed. Could it be that too many parallel test processes are being run on the win32 machine? |
As far as I can tell, win32 CI started failing with OOM after this PR. Putting up the revert to investigate whether it is indeed the root cause.
Reverts #44215