Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize jl_page_size when not calling julia_init. #44699

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Mar 22, 2022

If we load libjulia-codegen directly, e.g. from opt or llc, we don't call julia_init but init_llvm.
Introduced by #41936. Fixes #43727.

If we load libjulia-codegen directly, e.g. from opt or llc,
we don't call julia_init but init_llvm.
@maleadt maleadt added bugfix This change fixes an existing bug compiler:llvm For issues that relate to LLVM backport 1.8 Change should be backported to release-1.8 labels Mar 22, 2022
@maleadt maleadt requested a review from JeffBezanson March 22, 2022 17:58
@maleadt
Copy link
Member Author

maleadt commented Mar 23, 2022

win32 failure is unrelated (OOM)

@Keno Keno merged commit f562ad0 into master Mar 30, 2022
@Keno Keno deleted the tb/init_pagesize branch March 30, 2022 03:06
@maleadt maleadt removed the request for review from JeffBezanson March 30, 2022 06:16
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
If we load libjulia-codegen directly, e.g. from opt or llc,
we don't call julia_init but init_llvm.

Co-authored-by: Keno Fischer <keno@juliacomputing.com>
(cherry picked from commit f562ad0)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug compiler:llvm For issues that relate to LLVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can no longer run -julia pipeline from opt
3 participants