Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix oc lowering with return type annotations #44727

Merged
merged 2 commits into from
Mar 27, 2022
Merged

fix oc lowering with return type annotations #44727

merged 2 commits into from
Mar 27, 2022

Conversation

simeonschaub
Copy link
Member

fixes #44723

@simeonschaub simeonschaub added bugfix This change fixes an existing bug compiler:lowering Syntax lowering (compiler front end, 2nd stage) labels Mar 24, 2022
@simeonschaub simeonschaub added backport 1.7 backport 1.8 Change should be backported to release-1.8 labels Mar 24, 2022
tkf
tkf reviewed Mar 25, 2022
View reviewed changes
test/syntax.jl Outdated Show resolved Hide resolved
@KristofferC KristofferC mentioned this pull request Mar 25, 2022
Merged
22 tasks
@simeonschaub @tkf
Update test/syntax.jl
ded6839 
Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
@simeonschaub simeonschaub merged commit 19eb307 into master Mar 27, 2022
@simeonschaub simeonschaub deleted the sds/fix_44723 branch March 27, 2022 06:05
KristofferC pushed a commit that referenced this pull request Mar 28, 2022
@simeonschaub @KristofferC
fix oc lowering with return type annotations (#44727)
6a88865 
fixes #44723

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
(cherry picked from commit 19eb307)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Mar 29, 2022
@KristofferC KristofferC mentioned this pull request Apr 19, 2022
Merged
40 tasks
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@simeonschaub @KristofferC
fix oc lowering with return type annotations (#44727)
6e5b031 
fixes #44723

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
(cherry picked from commit 19eb307)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkf tkf tkf left review comments

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug compiler:lowering Syntax lowering (compiler front end, 2nd stage)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid syntax (gotoifnot (true) 0) from return type conversion of an opaque closure
3 participants
@simeonschaub @tkf @KristofferC