effects: replaces usages of ALWAYS_FALSE
with TRISTATE_UNKNOWN
#44808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although they are basically equivalent in the current implementation,
it would be more correct conceptually if we propagate
TRISTATE_UNKNOWN
instead of
ALWAYS_TRUE
, as it is hard or impossible to derive a globalconclusion from a local analysis on each statement in most places.
This commit also adds a docstring that simply explains the design of the
effect analysis.