elaborate @nospecialize docstring a bit
#44933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapted from #41931.
aviatesk
changed the title
@nospecialize docstring a bit@nospecialize docstring a bit
ianatol
reviewed
Apr 11, 2022
| or in the function body. | ||
| When applied to an argument, the macro must wrap the entire argument expression. | ||
| When applied to an argument, the macro must wrap the entire argument expression, e.g., | ||
| `@nospecialize(x::Real)` or `@nospecialize(i::Integer...)` rather than wrapping just the argument name. |
There was a problem hiding this comment.
This is not necessarily the case if the function only takes one argument:
julia> function h(@nospecialize x::Int)
x
end
h (generic function with 1 method)
julia> function f(@nospecialize x)
x
end
f (generic function with 1 method)Not sure whether it's worth it to elaborate on this small technicality here, but maybe we could give an example below that shows this way, since it is a bit cleaner imo
There was a problem hiding this comment.
They are general syntactical variants of syntax for invoking macros and I don't think we necessarily want to discuss it here again (as it's described in the manual).
ianatol
reviewed
Apr 11, 2022
| julia> f(A::AbstractArray) = g(A) | ||
| f (generic function with 1 method) | ||
|
|
||
| julia> @noinline g(@nospecialize(A::AbstractArray)) = A[1] |
There was a problem hiding this comment.
Suggested change
| julia> @noinline g(@nospecialize(A::AbstractArray)) = A[1] | |
| julia> @noinline g(@nospecialize A::AbstractArray) = A[1] |
for ex.,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from #41931.