Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix embedding with MSVC #44976

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Fix embedding with MSVC #44976

merged 1 commit into from
Apr 14, 2022

Conversation

barche
Copy link
Contributor

@barche barche commented Apr 14, 2022

Defines needed to enable embedding using MSVC on Windows, as suggested by @vtjnash (#44587 (comment))

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Apr 14, 2022
@DilumAluthge DilumAluthge merged commit c589e0d into JuliaLang:master Apr 14, 2022
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Apr 14, 2022
@barche barche deleted the fix-msvc-compile branch April 14, 2022 23:00
@Taaitaaiger
Copy link
Contributor

If it's still possible, I think this should be backported to 1.8 like #44842

@vtjnash vtjnash added backport 1.6 Change should be backported to release-1.6 backport 1.7 backport 1.8 Change should be backported to release-1.8 labels Apr 15, 2022
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@barche @KristofferC
Fix embedding with MSVC (#44976)
adf3a58 
(cherry picked from commit c589e0d)
@KristofferC KristofferC mentioned this pull request Apr 19, 2022
Merged
40 tasks
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@barche @KristofferC
Fix embedding with MSVC (#44976)
fe0faad 
(cherry picked from commit c589e0d)
@KristofferC KristofferC mentioned this pull request Apr 19, 2022
Merged
67 tasks
KristofferC pushed a commit that referenced this pull request May 16, 2022
@barche
Fix embedding with MSVC (#44976)
294b142 
(cherry picked from commit c589e0d)
@KristofferC KristofferC mentioned this pull request May 16, 2022
Merged
45 tasks
@KristofferC KristofferC removed backport 1.8 Change should be backported to release-1.8 backport 1.7 labels May 26, 2022
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 6, 2022
@ViralBShah ViralBShah mentioned this pull request Sep 5, 2022
Closed
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@barche
Fix embedding with MSVC (#44976)
e3f1d77 
(cherry picked from commit c589e0d)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@barche @staticfloat
Fix embedding with MSVC (#44976)
b0b9948 
(cherry picked from commit c589e0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barche @Taaitaaiger @vtjnash @KristofferC @DilumAluthge