Fix attributes for donotdelete intrinsic
#45010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in #44793 changed the signature of the donotdelete intrinsic, but didn't change the corresponding attributes, leaving a `nonnull` attribute on a `void` return, which fails the verifier.
pchintalapudi
approved these changes
Apr 17, 2022
| @@ -500,7 +500,7 @@ static AttributeList get_donotdelete_func_attrs(LLVMContext &C) | |||
| FnAttrs = FnAttrs.addAttribute(C, Attribute::NoUnwind); | |||
| return AttributeList::get(C, | |||
| FnAttrs, | |||
| Attributes(C, {Attribute::NonNull}), | |||
| Attributes(C, {}), | |||
There was a problem hiding this comment.
Can we just use the default constructor of AttributeSet here instead?
There was a problem hiding this comment.
Probably. I just submitted this as a quick drive-by while I was working on something else. Feel free to make a PR that fixes it better :).
KristofferC
added
backport 1.7
backport 1.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #44793 changed the signature of the donotdelete intrinsic,
but didn't change the corresponding attributes, leaving a
nonnullattributeon a
voidreturn, which fails the verifier.