Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenBLAS: Find objconv in its proper path #45391

Merged
merged 1 commit into from
May 21, 2022
Merged

OpenBLAS: Find objconv in its proper path #45391

merged 1 commit into from
May 21, 2022

Conversation

fxcoudert
Copy link
Contributor

This will fix part of #44517
and is one of the last few steps to allow a full source build on macOS.

Could it be backported to 1.8 before the release?

@fxcoudert fxcoudert mentioned this pull request May 20, 2022
Closed
@giordano giordano requested a review from staticfloat May 20, 2022 10:38
@giordano giordano added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries backport 1.8 Change should be backported to release-1.8 labels May 20, 2022
@ViralBShah ViralBShah merged commit 434d340 into JuliaLang:master May 21, 2022
@ViralBShah
Copy link
Member

I looked through the build files, and clearly the build dependencies are all in build_depsbindir.

@ViralBShah ViralBShah added the backport 1.6 Change should be backported to release-1.6 label May 21, 2022
@fxcoudert fxcoudert deleted the objconv branch May 21, 2022 15:31
@giordano giordano linked an issue May 21, 2022 that may be closed by this pull request
Build failure in OpenBLAS #44517
Closed
KristofferC pushed a commit that referenced this pull request May 23, 2022
@fxcoudert
OpenBLAS: Find objconv in its proper path (#45391)
823071e 
(cherry picked from commit 434d340)
This was referenced May 23, 2022
Merged
Merged
KristofferC pushed a commit that referenced this pull request May 23, 2022
@fxcoudert
OpenBLAS: Find objconv in its proper path (#45391)
8b94e68 
(cherry picked from commit 434d340)
KristofferC pushed a commit that referenced this pull request May 23, 2022
@fxcoudert
OpenBLAS: Find objconv in its proper path (#45391)
31f4b6c 
(cherry picked from commit 434d340)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 26, 2022
KristofferC pushed a commit that referenced this pull request Jul 4, 2022
@fxcoudert
OpenBLAS: Find objconv in its proper path (#45391)
12719ea 
(cherry picked from commit 434d340)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 6, 2022
@mkitti mkitti mentioned this pull request Sep 1, 2022
Closed
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@fxcoudert
OpenBLAS: Find objconv in its proper path (#45391)
e90a6ed 
(cherry picked from commit 434d340)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@fxcoudert @staticfloat
OpenBLAS: Find objconv in its proper path (#45391)
e5a9f55 
(cherry picked from commit 434d340)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat Awaiting requested review from staticfloat

Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure in OpenBLAS
4 participants
@fxcoudert @ViralBShah @giordano @KristofferC