-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deps/stdlib] put all version info in Versions.make
#45691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For stdlib, we actually want to keep each of the external stdlibs in their own file. See for example #41370 (comment). So this PR undoes the work we did in #42474.
#40430 was about deps, not stdlib. Can you remove the external stdlib changes from this PR?
There is one small problem. Because the installation of stdlib calls the function Perhaps we could reuse the deprecated arguments of the |
We don't want to do this for deps either, since it means we can't determine as accurately when they need to be updated, and it increases the chances that backporting something ends up in a merge conflict. But we could probably move the BB versions into the |
replace by: #45720 |
ref: #40430
*.version
files, and put all version info inVersions.make
libblastrampoline
andOpenBLAS
LibSSH2
, whyLIBSSH2_VER !== LIBSSH2_BRANCH
Maybe we can backport this pr to other versions.