Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deps] split
Versions.make
into standalone*.version
file #45720[deps] split
Versions.make
into standalone*.version
file #45720Changes from 18 commits
ba0d45d
3920564
b33e5c2
9e14d10
07c6f39
99a4538
c1c0910
2c12e0f
0d727d4
bda346a
1850865
741cd3a
809a97f
badc75d
ba29534
bae11d8
90b6055
634ceca
fd42fe3
2b47176
3e4ffb0
5051246
9e15c30
212eab6
6d01064
9e7b058
306eb9f
677e476
44a22d2
fd69fab
fd1b4d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inkydragon why this is here instead of its own file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because libgit2 depends on it directly.
The download and installation code is also placed in
libgit2.mk
.CA certificates can be split out as a separate dependency if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version mismatch, ref: #43250
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nalimilan Any thoughts on how to address this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.10.2 doesn't exist upstream, AFAICT that's a trick used in Yggdrasil. Cf. #43250 (comment) Maybe @mkitti knows.