Document that Length parameter needs Julia 1.7
#45961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Jul 8, 2022
Co-authored-by: Keno Fischer <keno@alumni.harvard.edu>
johnnychen94
reviewed
Jul 8, 2022
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
KristofferC
approved these changes
Jul 8, 2022
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
* Document that `L`ength parameter needs Julia 1.7 vtjnash added the 4th type parameter `L` in JuliaLang#41619 to `StepRangeLen`. That addition seems to have appeared in Julia 1.7 so it should be documented as such. I found this out the hard way because my CI for code that used `L` is failing with Julia 1.6. Co-authored-by: Johnny Chen <johnnychen94@hotmail.com> Co-authored-by: Keno Fischer <keno@alumni.harvard.edu>
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
* Document that `L`ength parameter needs Julia 1.7 vtjnash added the 4th type parameter `L` in JuliaLang#41619 to `StepRangeLen`. That addition seems to have appeared in Julia 1.7 so it should be documented as such. I found this out the hard way because my CI for code that used `L` is failing with Julia 1.6. Co-authored-by: Johnny Chen <johnnychen94@hotmail.com> Co-authored-by: Keno Fischer <keno@alumni.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vjnash added the 4th type parameter
Lin #41619 toStepRangeLen.That addition seems to have appeared in Julia 1.7 so it should be documented as such.
I found this out the hard way because my CI for code that used
Lis failing with Julia 1.6.