-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invoke
d calls: record invoke signature in backedges
#46010
Merged
Merged
Commits on Aug 22, 2022
-
Support adding backedges with invokesig
This allows a MethodInstance to store dispatch tuples as well as other MethodInstances among their backedges. The motivation is to properly handle invalidation with `invoke`, which allows calling a less-specific method and thus runs afoul of our standard mechanisms to detect "outdated" dispatch. Additionally: - provide backedge-iterators for both C and Julia that abstracts the specific storage mechanism. - fix a bug in the CodeInstance `relocatability` field, where methods that only return a constant (and hence store `nothing` for `inferred`) were deemed non-relocatable. - fix a bug in which #43990 should have checked that the method had not been deleted. Tests passed formerly simply because we weren't caching external CodeInstances that inferred down to a `Const`; fixing that exposed the bug. This bug has been exposed since merging #43990 for non-`Const` inference, and would affect Revise etc.
Configuration menu - View commit details
-
Copy full SHA for 7080f68 - Browse repository at this point
Copy the full SHA 7080f68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d5f1a8 - Browse repository at this point
Copy the full SHA 7d5f1a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e937235 - Browse repository at this point
Copy the full SHA e937235View commit details -
Configuration menu - View commit details
-
Copy full SHA for 737efc8 - Browse repository at this point
Copy the full SHA 737efc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5808545 - Browse repository at this point
Copy the full SHA 5808545View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa5c237 - Browse repository at this point
Copy the full SHA fa5c237View commit details -
Apply suggestions from code review
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1b9535b - Browse repository at this point
Copy the full SHA 1b9535bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1923b0 - Browse repository at this point
Copy the full SHA d1923b0View commit details
Commits on Aug 23, 2022
-
Cache invokesig in backedge data
Encode the `invokesig` in `ext_targets` so it gets cached to disk.
Configuration menu - View commit details
-
Copy full SHA for 5aaf76d - Browse repository at this point
Copy the full SHA 5aaf76dView commit details
Commits on Aug 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 945bcfc - Browse repository at this point
Copy the full SHA 945bcfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a9a87c - Browse repository at this point
Copy the full SHA 8a9a87cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.