Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unreliable jldoctest #46021

Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix unreliable jldoctest #46021

merged 1 commit into from
Jul 13, 2022

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Jul 13, 2022

Fix unreliable jldoctest introduced in #45306.

As shown e.g. in the doctest job https://buildkite.com/julialang/julia-master/builds/13830#0181f7c7-9994-4f84-a690-9cdb86480cbc.

Specifically, the incriminated number change will keep changing on addition / removal of any jldoctests in the source docstrings: e.g. it changed after merging #45137.

@t-bltg t-bltg marked this pull request as draft July 13, 2022 14:45
@t-bltg t-bltg marked this pull request as ready for review July 13, 2022 14:46
@DilumAluthge
Copy link
Member

Thank you @t-bltg!

@DilumAluthge
Copy link
Member

I'm merging this now because doctest is green.

@DilumAluthge DilumAluthge merged commit 9815a8e into JuliaLang:master Jul 13, 2022
@t-bltg t-bltg deleted the fix_doctest branch July 13, 2022 15:44
ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants