Disambiguate invalidation types in jl_insert_method_instance #46569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SnoopCompile parses the invalidation log to construct a causal chain for each invalidation. It turns out to be necessary to disambiguate invalidation of callers from invalidation of the primary trigger in jl_insert_method_instance.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SnoopCompile parses the invalidation log to construct a causal chain
for each invalidation. It turns out to be necessary to disambiguate
invalidation of callers from invalidation of the primary trigger
in
jl_insert_method_instance.This is a follow-on to #46010