Add a warning about inadvertent Diagonal(::Matrix) #46864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenhinkeller
added
docs
|
Do you know what the CI failures are? Seems good to go otherwise? |
brenhinkeller
approved these changes
Nov 26, 2022
|
The remaining failures seem totally unrelated, so I think we're good here |
brenhinkeller
added
the
merge me
dkarrasch
reviewed
Nov 28, 2022
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone was surprised that
Diagonal(sum(rand(5,5), dims=2))makes a 1×1 matrix. I thought perhaps the docstring ought to mention this.