Set intersection = 1 during intersect_sub_datatype
#46882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, the `subtype_in_env` check is performed without this flag, thus `var_lt`/`var_gt` might set the wrong bounds.
Keno
added
backport 1.8
|
We should perhaps check if this closed any others too! |
|
Would a backport to v1.6 be possible as well? |
Of course!
I took a quick look, but none of them looks related. Maybe we should add known intersect/subtype bug to the test file. |
KristofferC
pushed a commit
that referenced
this pull request
Sep 30, 2022
(cherry picked from commit e6d9979)
37 tasks
N5N3
added a commit
to N5N3/julia
that referenced
this pull request
Sep 30, 2022
close JuliaLang#38497 (fixed by JuliaLang#46882)
KristofferC
pushed a commit
that referenced
this pull request
Oct 28, 2022
(cherry picked from commit e6d9979)
78 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit e6d9979)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit e6d9979)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit e6d9979)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit e6d9979)
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit e6d9979)
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2023
(cherry picked from commit e6d9979)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the
subtype_in_envcheck is performed without this flag, thusvar_lt/var_gtmight set the wrong bounds.close #46871.