Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probe and dlopen() the correct libstdc++ #46976

Merged
merged 28 commits into from
Nov 8, 2022
Merged

Probe and dlopen() the correct libstdc++ #46976

merged 28 commits into from
Nov 8, 2022

Commits on Oct 25, 2022

  1. Probe if system libstdc++ is newer than ours 

    If the system libstdc++ is detected to be newer, load it.
Otherwise, load the one that we ship. This improves compatibility
with external shared libraries that the user might have on their
system.

Fixes JuliaLang#34276

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Co-authored-by: Elliot Saba <staticfloat@gmail.com>
    @giordano @vtjnash
    @staticfloat @vchuravy
    3 people authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    8a2ad6b View commit details
    Browse the repository at this point in the history

  2. Addressed review comments.

    @apaz-cli @vchuravy
    apaz-cli authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    314df3e View commit details
    Browse the repository at this point in the history

  3. Change error handling in wrapper functions 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @apaz-cli @vtjnash @vchuravy
    2 people authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    b395b0b View commit details
    Browse the repository at this point in the history

  4. Call write_wrapper three times instead of snprintf 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @apaz-cli @vtjnash @vchuravy
    2 people authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    128e8be View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @apaz-cli @vtjnash @vchuravy
    2 people authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    b4f876f View commit details
    Browse the repository at this point in the history

  6. Update cli/loader_lib.c 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @apaz-cli @vtjnash @vchuravy
    2 people authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    f423adb View commit details
    Browse the repository at this point in the history

  7. Reordered reading and waiting to avoid a deadlock.

    @apaz-cli @vchuravy
    apaz-cli authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    6d84325 View commit details
    Browse the repository at this point in the history

  8. Fixed obvious issues.

    @apaz-cli @vchuravy
    apaz-cli authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    2961b0f View commit details
    Browse the repository at this point in the history

  9. Only load libstdc++ preemptively on linux.

    @apaz-cli @vchuravy
    apaz-cli authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    6ff2bf5 View commit details
    Browse the repository at this point in the history

  10. Update cli/loader_lib.c 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @apaz-cli @vtjnash @vchuravy
    2 people authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    799c642 View commit details
    Browse the repository at this point in the history

  11. Update cli/loader_lib.c 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @apaz-cli @vtjnash @vchuravy
    2 people authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    c652040 View commit details
    Browse the repository at this point in the history

  12. Specified path to bundled libstdc++ on the command line.

    @apaz-cli @vchuravy
    apaz-cli authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    1574d22 View commit details
    Browse the repository at this point in the history

  13. Removed whitespace.

    @apaz-cli @vchuravy
    apaz-cli authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    213fdce View commit details
    Browse the repository at this point in the history

  14. Update cli/Makefile 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @apaz-cli @vtjnash @vchuravy
    2 people authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ea99107 View commit details
    Browse the repository at this point in the history

  15. Handled make install stringreplace.

    @apaz-cli @vchuravy
    apaz-cli authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ece7a5a View commit details
    Browse the repository at this point in the history

  16. Correctly quoted stringreplace.

    @apaz-cli @vchuravy
    apaz-cli authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    2788bc0 View commit details
    Browse the repository at this point in the history

  17. Added -Wl,--enable-new-dtags to prevent DT_RPATH for transitive depen… 

    …dencies
    @apaz-cli @vchuravy
    apaz-cli authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    c4a95e7 View commit details
    Browse the repository at this point in the history

  18. Updated news entry.

    @apaz-cli @vchuravy
    apaz-cli authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ca967aa View commit details
    Browse the repository at this point in the history

  19. Added comment about environment variable.

    @apaz-cli @vchuravy
    apaz-cli authored and vchuravy committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    4bf5699 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. patched rpath for libgfortran and libLLVM.

    @apaz-cli
    apaz-cli committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    3314c16 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Added explaination to Make.inc

    @apaz-cli
    apaz-cli committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    794e7a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Removed trailing space

    @apaz-cli
    apaz-cli committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    483a081 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mg/dlopen-libstdc++

    @staticfloat
    staticfloat authored Oct 29, 2022
    Configuration menu
    Copy the full SHA
    f570772 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Removed patchelf for libgfortran, now that BB has been fixed.

    @apaz-cli
    apaz-cli committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    2c9a17e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'mg/dlopen-libstdc++' of https://github.com/apaz-cli/julia… 

    … into mg/dlopen-libstdc++
    @apaz-cli
    apaz-cli committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    cc88e0e View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Merge remote-tracking branch 'origin/master' into mg/dlopen-libstdc++

    @apaz-cli
    apaz-cli committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    a8262e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Fixed typos and comments 

    Co-authored-by: Max Horn <max@quendi.de>
    @apaz-cli @fingolfin
    apaz-cli and fingolfin committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    f675f17 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Merge branch 'master' into mg/dlopen-libstdc++

    @apaz-cli
    apaz-cli committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    7685f15 View commit details
    Browse the repository at this point in the history