Add round(::Type{Complex{T}}, Complex{S})
#47128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
force-pushed
the
sf/complex_rounding
branch
from
40d1af3 to
9c3ee08
Compare
This is useful for doing things like `round.(Complex{Int16}, complex_data)`,
when you need to coerce to a single datatype.
staticfloat
force-pushed
the
sf/complex_rounding
branch
from
9c3ee08 to
e3d5ab7
Compare
|
Requesting review from @stevengj because GitHub suggested it. Feel free to point me toward someone else who might be more appropriate if necessary. |
|
@staticfloat have you seen #42060 |
stevengj
reviewed
Oct 18, 2022
| @@ -1100,6 +1100,11 @@ function round(z::Complex, rr::RoundingMode=RoundNearest, ri::RoundingMode=rr; k | |||
| round(imag(z), ri; kwargs...)) | |||
| end | |||
|
|
|||
| function round(::Type{Complex{T}}, z::Complex) where {T} | |||
There was a problem hiding this comment.
Shouldn't this take an optional r::RoundingMode argument?
(That starts to get into the question of defining complex floor from #42060?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for doing things like
round.(Complex{Int16}, complex_data), when you need to coerce to a single datatype.