Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of AMDGPU and CUDA #47334

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

jpsamaroo
Copy link
Member

Fixes loading of AMDGPU and then CUDA in the same session.

Written by @vtjnash and @vchuravy, who can describe what exactly this does if necessary 😄

Fixes #47331 and JuliaGPU/GPUCompiler.jl#362

@jpsamaroo jpsamaroo added types and dispatch Types, subtyping and method dispatch gpu Affects running Julia on a GPU labels Oct 26, 2022
@jpsamaroo jpsamaroo added this to the 1.9 milestone Oct 26, 2022
src/dump.c Outdated Show resolved Hide resolved
Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Oct 26, 2022
vchuravy added a commit that referenced this pull request Oct 26, 2022
Forward-port of #47334

Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
Co-authored-by: Jameson Nash <vtjnash@users.noreply.github.com>
Co-authored-by: Julian Samaroo <jpsamaroo@users.noreply.github.com>
@giordano giordano merged commit 0daab8a into JuliaLang:master Oct 27, 2022
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Oct 27, 2022
@jpsamaroo jpsamaroo deleted the jps/fix-amdgpu-cuda-dispatch branch October 27, 2022 01:26
vtjnash pushed a commit that referenced this pull request Nov 29, 2022
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
(cherry picked from commit 0daab8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpu Affects running Julia on a GPU types and dispatch Types, subtyping and method dispatch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression when using AMDGPU and CUDA in same session
3 participants