-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 5-arg mul!
for vectors of vectors
#47665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N5N3
reviewed
Nov 22, 2022
What happens if |
ranocha
added
backport 1.8
Change should be backported to release-1.8
backport 1.9
Change should be backported to release-1.9
labels
Nov 23, 2022
ranocha
force-pushed
the
hr/mul_vector_of_vectors
branch
from
November 23, 2022 08:20
3132cec
to
17112e5
Compare
I added additional tests with matrices of vectors/matrices - they work correctly in this PR. |
ranocha
force-pushed
the
hr/mul_vector_of_vectors
branch
from
November 24, 2022 07:39
17112e5
to
741ab6b
Compare
The only failing test is "test x86_64-w64-mingw32" with message "Received cancellation signal, interrupting", which does not seem to be related to this PR. |
Co-authored-by: N5N3 <2642243996@qq.com>
DilumAluthge
force-pushed
the
hr/mul_vector_of_vectors
branch
from
November 24, 2022 09:05
741ab6b
to
3e9761f
Compare
KristofferC
pushed a commit
that referenced
this pull request
Nov 28, 2022
KristofferC
pushed a commit
that referenced
this pull request
Nov 28, 2022
51 tasks
26 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On current
master
and release, vectors of vectors work with*
and 3-argmul!
but not with 5-argmul!
:Since matrix vector products only need to be able to
this is an unnecessary restriction I fixed here. In practice, this appears for us when multiplying vectors of
SVector
s from StaticArrays.jl (orStructArray
s thereof from StructArrays.jl) by matrices, e.g., when discretizing differential equations.