-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump libuv. #47707
Merged
Bump libuv. #47707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapts to the final version of the constrained/available memory APIs.
maleadt
added
the
external dependencies
Involves LLVM, OpenBLAS, or other linked libraries
label
Nov 25, 2022
giordano
reviewed
Nov 25, 2022
giordano
added
building
Build system, or building Julia or its dependencies
JLLs
labels
Nov 25, 2022
[ci skip]
@gbaraldi This also includes JuliaLang/libuv#29, which AFAIK you hadn't bumped to master yet? |
51 tasks
It works! Many thanks @maleadt for seeing this through.
|
simonbyrne
approved these changes
Nov 30, 2022
Thanks for verifying. CI failures look unrelated, so this seems good to go. |
Looks like this PR did not update the source checksums for libuv. |
KristofferC
pushed a commit
that referenced
this pull request
Dec 8, 2022
Adapts to the final version of the constrained/available memory APIs. (cherry picked from commit 41b73e2)
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
building
Build system, or building Julia or its dependencies
external dependencies
Involves LLVM, OpenBLAS, or other linked libraries
JLLs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #46796; now that all relevant PRs (notably libuv/libuv#3754) have been merged upstream, I've backported this to our branch, JuliaLang/libuv#32, and adapted to the API changes that were involved.
@simonbyrne This should fix the issue you encountered on a SLURM cgroup1 set-up, #46796 (comment); please verify.