Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libuv. #47707

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Bump libuv. #47707

merged 3 commits into from
Nov 30, 2022

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Nov 25, 2022

Follow-up on #46796; now that all relevant PRs (notably libuv/libuv#3754) have been merged upstream, I've backported this to our branch, JuliaLang/libuv#32, and adapted to the API changes that were involved.

@simonbyrne This should fix the issue you encountered on a SLURM cgroup1 set-up, #46796 (comment); please verify.

Adapts to the final version of the constrained/available memory APIs.
@maleadt maleadt added the external dependencies Involves LLVM, OpenBLAS, or other linked libraries label Nov 25, 2022
@giordano giordano added building Build system, or building Julia or its dependencies JLLs labels Nov 25, 2022
[ci skip]
@maleadt maleadt added the backport 1.9 Change should be backported to release-1.9 label Nov 25, 2022
@maleadt
Copy link
Member Author

maleadt commented Nov 25, 2022

@gbaraldi This also includes JuliaLang/libuv#29, which AFAIK you hadn't bumped to master yet?

@simonbyrne
Copy link
Contributor

It works! Many thanks @maleadt for seeing this through.

┌─[8]──[Tue Nov 29]──[17:08:08]────────────────────────────────────────
│ spjbyrne@login2:~/julia-6ba9fd56e5
├ srun --reservation=clima -t 00:20:00 --mem 4G --pty bash -l

┌─[1]──[Tue Nov 29]──[17:08:18]────────────────────────────────────────
│ spjbyrne@hpc-91-17:~/julia-6ba9fd56e5
├ bin/julia
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.10.0-DEV.75 (2022-11-30)
 _/ |\__'_|_|_|\__'_|  |  tb/libuv/6ba9fd56e5c (fork: 3 commits, 0 days)
|__/                   |

julia> Sys.total_memory() / 2^20
4096.0

julia> Sys.total_physical_memory() / 2^20
191858.4375

@maleadt
Copy link
Member Author

maleadt commented Nov 30, 2022

Thanks for verifying. CI failures look unrelated, so this seems good to go.

@maleadt maleadt merged commit 41b73e2 into master Nov 30, 2022
@maleadt maleadt deleted the tb/libuv branch November 30, 2022 06:37
@DilumAluthge
Copy link
Member

Looks like this PR did not update the source checksums for libuv.

KristofferC pushed a commit that referenced this pull request Dec 8, 2022
Adapts to the final version of the constrained/available memory APIs.

(cherry picked from commit 41b73e2)
@KristofferC KristofferC mentioned this pull request Dec 14, 2022
26 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants