Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize build_dir for generated headers #47783

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Dec 2, 2022

Alternative to #47755

Builds are compiled with:

clang ... -I. -I/home/vchuravy/julia/src

For out-of-tree builds this should mean that we prioritize the build dir.

Using -H we observe that if a generated header is present in the src dir:

. /home/vchuravy/julia/src/julia.h
.. /home/vchuravy/julia/src/jl_internal_funcs.inc

This is due to the semantics of #include "file" vs #include <file> in the C pre-processor.
The former is relative to the current header/source file, while the later uses the include directories.

After this change we observe:

. /home/vchuravy/julia/src/julia.h
.. ./jl_internal_funcs.inc

@vchuravy vchuravy added the building Build system, or building Julia or its dependencies label Dec 2, 2022
@vchuravy vchuravy requested a review from vtjnash December 2, 2022 16:56
@vchuravy vchuravy merged commit 0feaf5c into master Dec 4, 2022
@vchuravy vchuravy deleted the vc/generated_headers branch December 4, 2022 01:46
@vchuravy vchuravy added backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 backport 1.9 Change should be backported to release-1.9 labels Dec 4, 2022
KristofferC pushed a commit that referenced this pull request Dec 8, 2022
KristofferC pushed a commit that referenced this pull request Dec 14, 2022
@KristofferC KristofferC mentioned this pull request Dec 14, 2022
26 tasks
KristofferC pushed a commit that referenced this pull request Dec 14, 2022
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Dec 16, 2022
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6 Change should be backported to release-1.6 building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants