Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert promotions of abstract arrays inside other arrays #47893

Merged
merged 1 commit into from
Dec 19, 2022
Merged

revert promotions of abstract arrays inside other arrays #47893

merged 1 commit into from
Dec 19, 2022

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Dec 14, 2022 •
edited
Loading

Fixes #45511, fixes #44939, fixes #44821, reopens #43551.

@KristofferC KristofferC requested a review from vtjnash December 14, 2022 10:21
@KristofferC KristofferC mentioned this pull request Dec 14, 2022
Closed
@KristofferC KristofferC added the backport 1.9 Change should be backported to release-1.9 label Dec 14, 2022
This was referenced Dec 14, 2022
Merged
Merged
vtjnash
vtjnash reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. We might want to run a subset of PkgEval to check if someone tried to update to the new rule system and check if this might break that (in which case we might need to keep the first 2 rules, and just remove or change the 3rd to promote_type(T,S))

@KristofferC
Copy link
Member Author

We might want to run a subset of PkgEval to check if someone tried to update to the new rule system

Hopefully, we'll catch that in the PkgEval for 1.9. It feels a bit overkill to run an entire run here.

@KristofferC KristofferC merged commit 427432e into master Dec 19, 2022
@KristofferC KristofferC deleted the kc/promotions_arrays branch December 19, 2022 11:53
KristofferC added a commit that referenced this pull request Dec 19, 2022
@KristofferC
revert promotions of abstract arrays inside other arrays (#47893)
eba98e5 
(cherry picked from commit 427432e)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Dec 27, 2022
@maxfreu maxfreu mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@KristofferC @vtjnash