Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix half precision in system image #48010

Closed
wants to merge 1 commit into from
Closed

[Backport] Fix half precision in system image #48010

wants to merge 1 commit into from

Conversation

vchuravy
Copy link
Member

Noticed during #47184, I don't recall why I choose weak, but it causes an ABI mismatch.

@KristofferC
Copy link
Sponsor Member

We should make a new backports-release-1.8 branch and merge it in there so it goes through PkgEval etc.

@KristofferC KristofferC added the backport 1.8 Change should be backported to release-1.8 label Dec 27, 2022
@KristofferC KristofferC mentioned this pull request Dec 27, 2022
Merged
10 tasks
@KristofferC
Copy link
Sponsor Member

Included in #48011

@giordano giordano deleted the vc/bp_image_fp16 branch December 27, 2022 15:43
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC Awaiting requested review from KristofferC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchuravy @KristofferC