compact: Don't try to kill the same edge twice #48343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In IR like: ``` goto if not true goto if not true ``` our implementation of `kill_edge!` goes through recursively to kill all newly unreachable blocks. However, it was still attempting to schedule the newly unreachable block. Then, when it got to the next GotoIfNot, it wsa again attempting to kill the same edge, which would fail, because the edge had already been removed from the CFG. Fix that by telling IncrementalCompact not to attempt scheduling any blocks that were newly discovered to be dead.
Keno
force-pushed
the
kf/youonlylivetwice
branch
from
931a0bc to
09b6e5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IR like:
our implementation of
kill_edge!goes through recursively to kill all newly unreachable blocks. However, it was still attempting to schedule the newly unreachable block. Then, when it got to the next GotoIfNot, it wsa again attempting to kill the same edge, which would fail, because the edge had already been removed from the CFG. Fix that by telling IncrementalCompact not to attempt scheduling any blocks that were newly discovered to be dead.