Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent heap snapshot test to write to julia dir #48458

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Conversation

KristofferC
Copy link
Sponsor Member

Otherwise errors on PkgEval (and it is a good idea nonetheless): https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/9a67956_vs_17cfb8e/Profile.primary.log

ERROR: SystemError: opening file "/opt/julia/share/julia/stdlib/v1.9/Profile/test/32_3557048005887140.heapsnapshot": Read-only file system

@KristofferC KristofferC added ci Continuous integration backport 1.9 Change should be backported to release-1.9 labels Jan 30, 2023
@vchuravy vchuravy added the merge me PR is reviewed. Merge when all tests are passing label Jan 30, 2023
@maleadt
Copy link
Member

maleadt commented Jan 30, 2023

The profile test actually failed:

Profile                                           (2) |         failed at 2023-01-30T08:22:49.065
Error During Test at C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\share\julia\stdlib\v1.10\Profile\test\runtests.jl:281
  Got exception outside of a @test
  failed process: Process(`'C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\bin\julia.exe' -Cnative '-JC:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\lib\julia\sys.dll' --depwarn=error --check-bounds=yes -g1 --startup-file=no --startup-file=no -e 'using Profile; print(Profile.take_heap_snapshot("C:\Users\julia\AppData\Local\Temp\jl_cVcTCn67GL"))'`, ProcessExited(1)) [1]
  Stacktrace:
    [1] pipeline_error
      @ .\process.jl:565 [inlined]
    [2] read(cmd::Cmd)
      @ Base .\process.jl:449
    [3] read(cmd::Cmd, #unused#::Type{String})
      @ Base .\process.jl:458
    [4] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\share\julia\stdlib\v1.10\Profile\test\runtests.jl:283 [inlined]
    [5] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\share\julia\stdlib\v1.10\Test\src\Test.jl:1502 [inlined]
    [6] top-level scope
      @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\share\julia\stdlib\v1.10\Profile\test\runtests.jl:282
    [7] include
      @ .\Base.jl:456 [inlined]
    [8] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\share\julia\test\testdefs.jl:29 [inlined]
    [9] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\share\julia\stdlib\v1.10\Test\src\Test.jl:1502 [inlined]
   [10] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\share\julia\test\testdefs.jl:23 [inlined]
   [11] macro expansion
      @ .\timing.jl:501 [inlined]
   [12] runtests(name::String, path::String, isolate::Bool; seed::UInt128)
      @ Main C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\share\julia\test\testdefs.jl:21
   [13] kwcall(::NamedTuple{(:seed,), Tuple{UInt128}}, ::typeof(runtests), name::String, path::String)
      @ Main C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\share\julia\test\testdefs.jl:5
   [14] #invokelatest#2
      @ .\essentials.jl:825 [inlined]
   [15] kwcall(::NamedTuple{(:seed,), Tuple{UInt128}}, ::typeof(invokelatest), ::Any, ::Any, ::Any)
      @ Base .\essentials.jl:820
   [16] (::Distributed.var"#110#112"{Distributed.CallMsg{:call_fetch}})()
      @ Distributed C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\share\julia\stdlib\v1.10\Distributed\src\process_messages.jl:285
   [17] run_work_thunk(thunk::Distributed.var"#110#112"{Distributed.CallMsg{:call_fetch}}, print_error::Bool)
      @ Distributed C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\share\julia\stdlib\v1.10\Distributed\src\process_messages.jl:70
   [18] macro expansion
      @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-6e145e4ba0\share\julia\stdlib\v1.10\Distributed\src\process_messages.jl:285 [inlined]
   [19] (::Distributed.var"#109#111"{Distributed.CallMsg{:call_fetch}, Distributed.MsgHeader, Sockets.TCPSocket})()
      @ Distributed .\task.jl:514

@IanButterworth IanButterworth merged commit 94c4fb5 into master Jan 31, 2023
@IanButterworth IanButterworth deleted the kc/profile_heap branch January 31, 2023 04:48
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 31, 2023
KristofferC added a commit that referenced this pull request Feb 1, 2023
Co-authored-by: Ian <i.r.butterworth@gmail.com>
(cherry picked from commit 94c4fb5)
@KristofferC KristofferC mentioned this pull request Feb 1, 2023
35 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants