Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompile: do not reanimate zombie external methods #48475

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Jan 31, 2023

Backedges are only applicable to cache objects with max_world==Inf

Fix #48391

@vtjnash vtjnash added compiler:precompilation Precompilation of modules bugfix This change fixes an existing bug backport 1.9 Change should be backported to release-1.9 labels Jan 31, 2023
@maleadt
Copy link
Member

maleadt commented Feb 1, 2023

Confirmed that this also fixes the SurrealNumbers.jl issue outside of the MWE.

@KristofferC KristofferC mentioned this pull request Feb 1, 2023
35 tasks
@maleadt maleadt force-pushed the jn/48391 branch 2 times, most recently from cde2ec9 to 9206f7f Compare February 3, 2023 09:18
@maleadt maleadt added the merge me PR is reviewed. Merge when all tests are passing label Feb 3, 2023
Backedges are only applicable to cache objects with max_world==Inf

Fix #48391
@maleadt maleadt merged commit b9398a3 into master Feb 4, 2023
@maleadt maleadt deleted the jn/48391 branch February 4, 2023 08:52
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Feb 4, 2023
KristofferC pushed a commit that referenced this pull request Feb 6, 2023
Backedges are only applicable to cache objects with max_world==Inf

Fix #48391
vtjnash added a commit that referenced this pull request Feb 6, 2023
Backedges are only applicable to cache objects with max_world==Inf

Fix #48391

(cherry picked from commit b9398a3)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug compiler:precompilation Precompilation of modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal instruction during sort (related to package precompilation)
4 participants