Subtype: skip more identical check for X::Tuple <: Y::Tuple
#48534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`jl_is_unionall(xi) == jl_is_unionall(yi) == 0` here.
Should improve the performance where `Y` has fixed length. Fix the example from JuliaLang#39967. The root cause there is a exponential growth in Left union. Fortunately, we won't encounter this problem for concrete `X`, as there's no 0-depth `Union`.
N5N3
added
performance
|
Test failure should be unrelated. And there seems no need to bother Nanosoldier. |
vtjnash
approved these changes
Feb 7, 2023
KristofferC
pushed a commit
that referenced
this pull request
Apr 13, 2023
Subtype: skip more identical check for `X::Tuple <: Y::Tuple` (cherry picked from commit e3dfcc3)
N5N3
added a commit
to N5N3/julia
that referenced
this pull request
Apr 24, 2023
Subtype: skip more identical check for `X::Tuple <: Y::Tuple` (cherry picked from commit e3dfcc3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should improve the performance where
Yhas fixed length.Fix the example from #39967.
The root cause there is an exponential growth in Left union.
Fortunately, we won't encounter this problem for concrete
X,as there's no 0-depth
Union.close #39967 (very limited though.)