Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ssavalue check for hoisting loads #48939

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Mar 7, 2023

Should fix #48917
We might want to do a PkgEval with Julia and LLVM assertions

@KristofferC KristofferC added the backport 1.9 Change should be backported to release-1.9 label Mar 7, 2023
@vchuravy
Copy link
Member

vchuravy commented Mar 7, 2023

@nanosoldier runtests(configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],), vs_configuration = (buildflags = ["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@gbaraldi
Copy link
Member Author

gbaraldi commented Mar 8, 2023

I tested some of the failing/timing out tests and they seem to work locally.

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Mar 8, 2023
@vtjnash vtjnash merged commit 9ef2c90 into JuliaLang:master Mar 8, 2023
@vtjnash vtjnash removed the merge me PR is reviewed. Merge when all tests are passing label Mar 8, 2023
@KristofferC KristofferC mentioned this pull request Mar 24, 2023
52 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 31, 2023
Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instruction does not dominate all uses!, getelementptr inbounds when testing DimensionalData
5 participants