Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for #48961 #49014

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Add test for #48961 #49014

merged 1 commit into from
Mar 16, 2023

Conversation

N5N3
Copy link
Member

@N5N3 N5N3 commented Mar 15, 2023

This was caused by the shared Lunion between fast path and normal path.
#48441 has fixed it by making sure forall_exists_equal never changes global Lunion.
close #48961.

@N5N3 N5N3 added test This change adds or pertains to unit tests types and dispatch Types, subtyping and method dispatch merge me PR is reviewed. Merge when all tests are passing labels Mar 15, 2023
@N5N3 N5N3 merged commit 5960b52 into JuliaLang:master Mar 16, 2023
@N5N3 N5N3 deleted the test48961 branch March 16, 2023 02:03
@KristofferC KristofferC added the backport 1.9 Change should be backported to release-1.9 label Mar 16, 2023
oscardssmith pushed a commit to oscardssmith/julia that referenced this pull request Mar 20, 2023
@N5N3 @oscardssmith
Add test for JuliaLang#48961 (JuliaLang#49014)
c3ec23c
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Mar 21, 2023
@KristofferC KristofferC mentioned this pull request Mar 24, 2023
Merged
52 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 31, 2023
Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
@N5N3 @Xnartharax
Add test for JuliaLang#48961 (JuliaLang#49014)
9f4eaa5
@N5N3 N5N3 mentioned this pull request May 18, 2023
Closed
@kpamnany kpamnany mentioned this pull request May 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
test This change adds or pertains to unit tests types and dispatch Types, subtyping and method dispatch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vector eltype depends on code executed before - only 1.9rc
4 participants
@N5N3 @vtjnash @giordano @KristofferC