Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further relax another piece of the AbstractQ tests #49334

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

staticfloat
Copy link
Member

Judging by the other Matrix(Q) tests, this should be an approximate equals. Testing with Apple Accelerate shows that all errors are on the order of 1e-16.

Judging by the other `Matrix(Q)` tests, this should be an approximate
equals.  Testing with Apple Accelerate shows that all errors are on the
order of `1e-16`.
@staticfloat staticfloat requested a review from dkarrasch April 12, 2023 19:05
@staticfloat staticfloat added the linear algebra Linear algebra label Apr 12, 2023
Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Matrix(Q) computes Q*Matrix(I) (in-place), whereas Q[:,1:3] computes "Q*Matrix(I)[:,1:3]".

@dkarrasch dkarrasch added the merge me PR is reviewed. Merge when all tests are passing label Apr 12, 2023
@staticfloat staticfloat merged commit 46e27e9 into master Apr 12, 2023
@staticfloat staticfloat deleted the sf/accelerate_fixes branch April 12, 2023 20:13
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants