Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve effects of objectid and getindex(::Dict) #49447

Merged
merged 11 commits into from
Apr 25, 2023
Merged

improve effects of objectid and getindex(::Dict) #49447

merged 11 commits into from
Apr 25, 2023

Commits on Apr 20, 2023

  1. improve effects of and

    @oscardssmith
    oscardssmith committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    0b05542 View commit details
    Browse the repository at this point in the history

  2. Update dict.jl

    @oscardssmith
    oscardssmith authored Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ffdb5b9 View commit details
    Browse the repository at this point in the history

  3. objectid is only sometimes foldable

    @oscardssmith
    oscardssmith committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ddabfcf View commit details
    Browse the repository at this point in the history

  4. bugfix

    @oscardssmith
    oscardssmith committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    a8b6812 View commit details
    Browse the repository at this point in the history

  5. address codereview

    @oscardssmith
    oscardssmith committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    1cafd9c View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. add tests

    @oscardssmith
    oscardssmith committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7866aa2 View commit details
    Browse the repository at this point in the history

  2. isimmutable is too strong

    @oscardssmith
    oscardssmith committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    ec974b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Update reflection.jl

    @oscardssmith
    oscardssmith authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    9619c1e View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Apply suggestions from code review

    @aviatesk
    aviatesk authored Apr 25, 2023
    Configuration menu
    Copy the full SHA
    2bcb4d9 View commit details
    Browse the repository at this point in the history

  2. fix up and enrich test cases

    @aviatesk
    aviatesk committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9bff927 View commit details
    Browse the repository at this point in the history

  3. mark Module type as identityfree

    @aviatesk
    aviatesk committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    a582220 View commit details
    Browse the repository at this point in the history