Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more Effects system docs #49652

Merged
merged 7 commits into from
May 9, 2023
Merged

Add some more Effects system docs #49652

merged 7 commits into from
May 9, 2023

Conversation

sjkelly
Copy link
Contributor

@sjkelly sjkelly commented May 5, 2023

  • add docs for Base.infer_effects
  • add show decoder in Effects docs

@sjkelly sjkelly requested a review from aviatesk May 5, 2023 16:24
vchuravy
vchuravy reviewed May 5, 2023
View reviewed changes
base/reflection.jl Outdated Show resolved Hide resolved
@sjkelly sjkelly force-pushed the sjk/effects_docs1 branch from fc0790b to 6586d1e Compare May 5, 2023 19:40
aviatesk
aviatesk reviewed May 6, 2023
View reviewed changes
base/compiler/effects.jl Outdated Show resolved Hide resolved
base/reflection.jl Outdated Show resolved Hide resolved
base/reflection.jl Outdated Show resolved Hide resolved
base/reflection.jl Outdated Show resolved Hide resolved
sjkelly and others added 4 commits May 8, 2023 09:46
@sjkelly @aviatesk
Update base/compiler/effects.jl
4622d63 
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
@sjkelly @aviatesk
Update base/reflection.jl
20fa12f 
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
@sjkelly @aviatesk
Update base/reflection.jl
c73790b 
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
@sjkelly @aviatesk
Update base/reflection.jl
bbeff66 
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
@sjkelly
Copy link
Contributor Author

sjkelly commented May 8, 2023

Thanks for the corrections @aviatesk !

@aviatesk aviatesk merged commit 7ef78e4 into JuliaLang:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topolarity topolarity topolarity left review comments

@vchuravy vchuravy vchuravy left review comments

@aviatesk aviatesk aviatesk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sjkelly @vchuravy @aviatesk @topolarity