fix missing gc root on store to iparams #49820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to optimize the order of this code a bit more, given that these checks are somewhat infrequently to be needed. Fix #49762
vtjnash
added
types and dispatch
|
Any test that can be added? |
|
Not really. You have to get the timing of GC just right for it to fail. But as long as CI passes, you know it is fixed. |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
vtjnash
added a commit
that referenced
this pull request
May 16, 2023
This simplifies the types, which may help subtyping other other similar lookup code any time this is later used as a parameter, so it is probably worthwhile to do. This is a followup to #49820, where we reorganized the code to make this more straightforward.
51 tasks
|
The |
|
I think you can hard-code it to |
vtjnash
added a commit
that referenced
this pull request
May 22, 2023
This simplifies the types, which may help subtyping other other similar lookup code any time this is later used as a parameter, so it is probably worthwhile to do. This is a followup to #49820, where we reorganized the code to make this more straightforward.
KristofferC
pushed a commit
that referenced
this pull request
Jun 27, 2023
|
Backporting this seems to cause the following: #50090 (comment). I removed it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to optimize the order of this code a bit more, given that these checks are somewhat infrequently to be needed.
Fix #49762