Docs: add examples to istril/istriu docstrings
#49853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jishnub
changed the title
istril/istriuistril/istriu docstrings
jishnub
added
linear algebra
KristofferC
reviewed
May 22, 2023
|
The added examples seem to demonstrate the same thing as the first example of respective docstring? |
|
Yes, it's the same thing, but the banded structure made it easier for me to grasp the idea, so I thought of including such examples. Perhaps only one example needs to be added, though, so I'll remove the middle one in each case. |
|
Gentle bump. If this seems reasonable, I would like to update the example, as the new one seems clearer to me |
|
Gentle bump. If there are no objections, this should be good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, simplify some of the examples to focus on the structure of the matrices