-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't permalloc the pkgimgs, but add option for PkgCacheInspector #49940
Conversation
Nominated for backport to 1.9 since it reduces memory usage significantly. |
Do you have some numbers to share? |
Omnipackage v1.9.0
1.10 with this PR
Just Trixi 1.8
1.9
1.10 with Patch
using |
Can you add to the table 1.10 without the PR? (just for fairness) |
I think you start seeing benefits if you load the same package in multiple processes, because with this we can share |
Should this be backported to Julia v1.9.1? |
If this is the case, it would be great for our HPC applications using MPI |
It might be too late for 1.9.1. @KristofferC ? |
For 1.9.1 yes. |
Thanks for the info - and for all the hard work on Julia, every new release, backports etc. I'm looking forward to v1.9.1 - and v1.9.2 including this fix 🙂 |
(cherry picked from commit 229269b)
(cherry picked from commit 229269b)
(cherry picked from commit 229269b)
This saves some memory when loading the package images.
The option restores the current behavior for packages like https://github.com/timholy/PkgCacheInspector.jl to keep working.
This is a rebase of #48215
We might want to backport this to 1.9