Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xsaves from Zen cpuspec #50186

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Remove xsaves from Zen cpuspec #50186

merged 1 commit into from
Jun 15, 2023

Conversation

vchuravy
Copy link
Member

Fixes #50102

As far as I understand it xsaves is broken on zenver1 and zenver2, and the Linux kernel disables that.
Weirdly enough in #50102 we are running on AMD EPYC 7B13 which is zenver3 and the it reports not having xsaves.

I don't think we are using it (maybe we should look into xsavec for task-switching xD )
so it should be safe to remove it from the set of required extensions.

@vchuravy vchuravy added this to the 1.10 milestone Jun 15, 2023
@vchuravy vchuravy added kernel bug 🤯 This is really a bug in the underlying OS kernel backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 backport 1.9 Change should be backported to release-1.9 pkgimage labels Jun 15, 2023
@vchuravy vchuravy merged commit 432f300 into master Jun 15, 2023
@vchuravy vchuravy deleted the vc/xsaves branch June 15, 2023 22:41
@giordano
Copy link
Contributor

For the record, I noticed archspec-json doesn't list xsaves anywhere. I asked @alalazo on Spack slack about why this feature is completely ignored and the answer was

Iirc this dates back to the initial implementation of archspec, and we noticed (2019) that XSAVES was not reliably exposed on all operating systems. Given that:

  1. If not exposed, it prevented the detection of architecture that could use AVX512
  2. It wasn't the only instruction that allowed to distinguish between two architectures

we decided to leave it out on detection

KristofferC pushed a commit that referenced this pull request Jun 26, 2023
@KristofferC KristofferC mentioned this pull request Jun 26, 2023
36 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jul 10, 2023
KristofferC pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 kernel bug 🤯 This is really a bug in the underlying OS kernel pkgimage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images not portable between znver3 and "AMD EPYC 7B13" (missing xsaves feature)
4 participants