Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically a continuation from #43366.
It shows similar promise for
pfib
, but I was actually motivatedby the benchmark in #50202 (comment)
where we did a lot of work trying to figure out if there are no more tasks to run.
One issue I am aware off is that the underlying data-structure is not GC friendly.
Fundamentally we will only copy over data in the buffer, we are gurantueed to only
read valid data, but on the unused pieces of the buffer we have task-corpses laying
around.
A second issue is that the current implementation only allows for one thread to
push!
andpopfirst!
,while all other threads are only allowed to
steal!
.It looks like Go uses a double-ended queue.