Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect results in expm1(::Union{Float16, Float32}) #50989

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix incorrect results in expm1(::Union{Float16, Float32}) #50989

merged 2 commits into from
Aug 21, 2023

Commits on Aug 20, 2023

  1. fix UB in `expm1(::Union{Float16, Float32}) 

    `unsafe_trunc(UInt, -1.0)` is UB but worked fine on apple and AMD so we didn't notice??? This has been very broken since 1.7
    @oscardssmith
    oscardssmith authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    b37bc9a View commit details
    Browse the repository at this point in the history

  2. add test

    @oscardssmith
    oscardssmith authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    b6aaa57 View commit details
    Browse the repository at this point in the history