Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify call to promote_eltype with repeated elements #51135

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Aug 31, 2023

Helps to short-circuit calls to large splat calls, since those have all the same type elements.

Fixes #51011

Helps to short-circuit calls to large splat calls, since those have all
the same type elements.

Fixes #51011
@brenhinkeller brenhinkeller added performance Must go faster bugfix This change fixes an existing bug labels Sep 1, 2023
@vtjnash vtjnash requested a review from JeffBezanson September 1, 2023 14:13
@vtjnash vtjnash merged commit 3527213 into master Sep 1, 2023
@vtjnash vtjnash deleted the jn/51011 branch September 1, 2023 18:50
KristofferC pushed a commit that referenced this pull request Nov 28, 2023
Helps to short-circuit calls to large splat calls, since those have all
the same type elements.

Fixes #51011

(cherry picked from commit 3527213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug performance Must go faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using SparseArrays makes vcat'ing adjoint vectors memory hog, regression in Julia 1.10 beta
2 participants