Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump LLVM to 15.0.7-9 #51863

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Bump LLVM to 15.0.7-9 #51863

merged 1 commit into from
Oct 26, 2023

Conversation

vchuravy
Copy link
Member

Contains a fix for AMDGPU.jl

cc: @pxl-th

@vchuravy vchuravy added compiler:llvm For issues that relate to LLVM backport 1.10 Change should be backported to the 1.10 release labels Oct 25, 2023
This was referenced Oct 26, 2023
Merged
Merged
@vchuravy vchuravy merged commit 75881a9 into master Oct 26, 2023
2 checks passed
@vchuravy vchuravy deleted the vc/bump_llvm15 branch October 26, 2023 20:39
vchuravy added a commit that referenced this pull request Oct 27, 2023
@vchuravy
Backport LLVM 15.0.7-9 to 1.10 (#51882)
1fe4e26 
Backport of #51863
@maleadt
Copy link
Member

maleadt commented Oct 30, 2023 •
edited
Loading

This bump removed several targets from the macOS release, breaking GPUCompiler.jl CI:

❯ git checkout 75881a9
HEAD is now at 75881a9edd Bump LLVM to 15.0.7-9 (#51863)

❯ rm -rf usr; make -C deps install-llvm && ./usr/tools/llvm-config --targets-built
WebAssembly BPF AVR AArch64

❯ git checkout 75881a9~
HEAD is now at 837522aadd Added tests for load_overrides() in Artifacts.jl (#51833)

❯ rm -rf usr; make -C deps install-llvm && ./usr/tools/llvm-config --targets-built
NVPTX AMDGPU WebAssembly BPF AVR AArch64

Was this intentional?

EDIT: I guess it was, to fix the LLVM 16 build: JuliaPackaging/Yggdrasil@4043601.

@gbaraldi
Copy link
Member

I think we would be able to make it build again, but those targets are also not support in apple anyway.

@maleadt
Copy link
Member

maleadt commented Oct 30, 2023

Sure, but it's very convenient that you can run the whole GPUCompiler test suite from any platform.
Anyway, GPUCompiler#master already disables testing of those platforms on macOS.

KristofferC added a commit that referenced this pull request Nov 2, 2023
@KristofferC
Backports release 1.10 (#51563)
1391444 
Backported PRs:
- [x] #50932 <!-- types: fix hash values of Vararg -->
- [x] #50975 <!-- Use rr-safe `nopl; rdtsc` sequence -->
- [x] #50989 <!-- fix incorrect results in `expm1(::Union{Float16,
Float32})` -->
- [x] #51284 <!-- Avoid infinite loop when doing SIGTRAP in arm64-apple
-->
- [x] #51332 <!-- Add s4 field to Xoshiro -->
- [x] #51397 <!-- call Pkg precompile hook in latest world -->
- [x] #51405 <!-- Remove fallback that assigns a module to inlined
frames. -->
- [x] #51491 <!-- Throw clearer ArgumentError for strip with two string
args -->
- [x] #51531 <!-- fix `_tryonce_download_from_cache` (busybox.exe
download error) -->
- [x] #51541 <!-- Fix string index error in tab completion code -->
- [x] #51530 <!-- Don't mark nonlocal symbols as hidden -->
- [x] #51557 <!-- Fix last startup & shutdown precompiles -->
- [x] #51512 <!-- avoid limiting Type{Any} to Type -->
- [x] #51595 <!-- reset `maxprobe` on `empty!` -->
- [x] #51582 <!-- Aggressive constprop in LinearAlgebra.wrap -->
- [x] #51592 <!-- correctly track element pointer in heap snapshot -->
- [x] #51326 <!-- complete false & true more generally as vals -->
- [x] #51376 <!-- make `hash(::Xoshiro)` compatible with `==` -->
- [x] #51557 <!-- Fix last startup & shutdown precompiles -->
- [x] #51845 
- [x] #51840 
- [x] #50663 <!-- Fix Expr(:loopinfo) codegen -->
- [x] #51863 <!-- LLVM 15.0.7-9 -->

Contains multiple commits, manual intervention needed:

- [ ] #51035 <!-- refactor GC scanning code to reflect jl_binding_t are
now first class -->
- [ ] #51092 <!-- inference: fix bad effects for recursion -->

Non-merged PRs with backport label:
- [ ] #51479 <!-- prevent code loading from lookin in the versioned
environment when building Julia -->
- [ ] #51414 <!-- improvements on GC scheduler shutdown -->
- [ ] #51366 <!-- Handle infix operators in REPL completion -->
- [ ] #50919 <!-- Code loading: do the "skipping mtime check for stdlib"
check regardless of the value of `ispath(f)` -->
- [ ] #50824 <!-- Add some aliasing warnings to docstrings for mutating
functions in Base -->
- [ ] #49805 <!-- Limit TimeType subtraction to AbstractDateTime -->
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbaraldi gbaraldi gbaraldi approved these changes

Assignees
No one assigned
Labels
compiler:llvm For issues that relate to LLVM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vchuravy @maleadt @gbaraldi @KristofferC