Fixes for armv7l buildbots #51945
Draft
Fixes for armv7l buildbots #51945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
system:32-bit
vtjnash
reviewed
Oct 30, 2023
staticfloat
force-pushed
the
sf/armv7l_fixes
branch
from
96d3c9b
to
885bfcd
Compare
|
Alright, next up, a bus error during bootstrap: |
|
According to asm-generic/siginfo.h on my system, that is: |
|
I managed to catch it in I'll see if the same happens with a debug build, just to try for a better stacktrace. |
|
I tried running a |
|
Try again with #52182 merged perhaps? |
staticfloat
force-pushed
the
sf/armv7l_fixes
branch
from
06ede9a
to
a82e3bd
Compare
|
Sadly, it doesn't seem to help (yet) |
staticfloat
force-pushed
the
sf/armv7l_fixes
branch
from
a82e3bd
to
8923976
Compare
|
I let it run for about an hour on my ARMv7 board until I hit: Note that I think it is the statement earlier that failed, and gdb is showing the wrong address, as that vstr is clearly aligned, and that vldr from $r12 is clearly not aligned. |
staticfloat
force-pushed
the
sf/armv7l_fixes
branch
from
8923976
to
6a21219
Compare
|
The IR we emit (on x86) is correct with regards to this alignment being align=1, so seems like this might be an ARM backend mistake in LLVM |
|
I followed your steps as well on one of the pibot machines, I got a very similar result: Mine showed |
|
Hi, I get a build error similar to the one below while building on host with docker buildx:
What I get when I cancel a hang: What might be interesting is when I follow a similar procedure on Raspberry Pi 4, I get more informative segfaults. When it's run with gdb: |
staticfloat
force-pushed
the
sf/armv7l_fixes
branch
from
2d51ea6
to
79e3aa2
Compare
|
I've rebased in an attempt to see where we stand now that LLVM v16 has been merged. |
|
Looks like we end up with a new error: |
|
Are we likely to get further if remove neon, vfp4 and all the vector instruction stuff? |
Jameson points out that ARM doesn't use the usual structure for these registers, and so we have to manually typecast this structure. X-ref: #47345 (comment)
staticfloat
force-pushed
the
sf/armv7l_fixes
branch
from
79e3aa2
to
25e57f1
Compare
|
Jameson and I have been debugging this today; so far we've discovered the following:
|
|
Tracked this down. That failure comes from an ABI decision that gets made during the configure of libstdc++ depending on what features it can autodetect of the platform architecture was being used ( So to fix, IIUC, you need to configure the compiler with --with-libstdcxx-lock-policy=atomics to prevent the ABI from changing depending on the autodetected behavior for that. And/or ensure that the libstdc++ library is being compiled with atomics correctly enabled for the current architectural target (e.g. we make sure armv6 and armv7hf are using different compiler shards, since they have mutually incompatible ABIs for both atomics and float registers) |
Ah, at the moment we're using the same toolchain, only with different -march switches |
|
So it sounds like the path forward here is to rebuild our C++ dependencies (likely just LLVM, in practice) with toolchains that have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a new armv7l build farm; this branch is collecting the fixes necessary to get Julia building on that platform again.