RFC: make UndefVarError messages more precise and informative #51979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
reviewed
Nov 1, 2023
JeffBezanson
reviewed
Nov 1, 2023
JeffBezanson
reviewed
Nov 1, 2023
JeffBezanson
reviewed
Nov 1, 2023
JeffBezanson
reviewed
Nov 1, 2023
JeffBezanson
reviewed
Nov 1, 2023
|
This is great! 🎉 |
vtjnash
added a commit
to JuliaLang/Distributed.jl
that referenced
this pull request
Nov 2, 2023
vtjnash
added a commit
to JuliaLang/Distributed.jl
that referenced
this pull request
Nov 3, 2023
vtjnash
added a commit
to JuliaLang/Distributed.jl
that referenced
this pull request
Nov 3, 2023
Record the 'scope' of the variable that was undefined (the Module, or a descriptive word such as :local or :static_parameter). Add that scope to the error message, and expand the hint suggestions added by the REPL to include more specific advice on common mistakes: - forgetting to set an initial value - forgetting to import a global - creating a local of the same name as a global - not matching a static parameter in a signature subtype Fixes #17062 (although more could probably be done to search for typos using REPL.string_distance and getting the method from stacktrace) Fixes #18877 Fixes #25263 Fixes #35126 Fixes #39280 Fixes #41728 Fixes #48731 Fixes #49917 Fixes #50369
vtjnash
force-pushed
the
jn/undefvarmessage
branch
from
434809b
to
b985793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record the 'scope' of the variable that was undefined (the Module, or a descriptive word such as :local or :static_parameter). Add that scope to the error message, and expand the hint suggestions added by the REPL to include more specific advice on common mistakes:
Fixes #17062 (although more could probably be done to search for typos using REPL.string_distance and getting the method from stacktrace)
Fixes #18877
Fixes #25263
Fixes #35126
Fixes #39280
Fixes #41728
Fixes #48731
Fixes #49917
Fixes #50369
(this needs a fix to a Distributed test, which can be done concurrent with any discussion about exact wording here)